This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
fix: fix name-pubsub test #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing a name.resolve to subscribe should not be expected to reject in the second test because both tests use the same node(which should be changed) and in the second test name.resolve will resolve because the nodes already now about each other.
achingbrain
suggested changes
Mar 12, 2020
|
I think you need to update the |
achingbrain
approved these changes
Apr 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a name.resolve to subscribe should not be expected to reject in the second test because both tests use the same nodes(which should be changed) and in the second test name.resolve will resolve because the nodes already now about each other.
Check this PR for CI ipfs/js-ipfs#2932